Conversation
product-auto-label
bot
added
the
api: firestore
This reverts commit 9edc6af.
dlarocque
force-pushed
the
dl/subq
branch
2 times, most recently
from
850ba24 to
dd1a205
Compare
cherylEnkidu
requested changes
Mar 31, 2026
Contributor
cherylEnkidu
left a comment
cherylEnkidu
left a comment
There was a problem hiding this comment.
can you add this test as well: https://github.com/googleapis/java-firestore/pull/2323/changes#diff-566df7e9507530a3a2b0c886b9408ac028ed2f741506e4ed33a3b4075ea36672R986
Also implement the check when calling subcollection in Union stage
cherylEnkidu
approved these changes
Apr 2, 2026
MarkDuckworth
approved these changes
Apr 2, 2026
Contributor
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
LGTM with suggestions for ref doc cleanup
MarkDuckworth
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
MarkDuckworth
approved these changes
Apr 8, 2026
Contributor
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
Approved with some minor documentation improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Pipeline subqueries.
Ported from: firebase/firebase-android-sdk#7736
API Proposal: go/firestore-pipelines-subquery